Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using WinUI DropDownButton #140

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Using WinUI DropDownButton #140

merged 1 commit into from
Sep 21, 2023

Conversation

niels9001
Copy link
Collaborator

We were using the OS DropDownButton instead of WinUI, resulting in a slightly different style and no animated icon.

@michael-hawker
Copy link
Member

Ah, this makes sense as to why it looked funny in some places, eh?

Is this part of CommunityToolkit/Windows#231 (or being tested) there as well?

@Arlodotexe want to check this on WASM?

Arlodotexe
Arlodotexe approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may be missing an icon on WASM, but it looks good otherwise

image

@niels9001 niels9001 merged commit 8048b48 into main Sep 21, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/dropdownbutton-fix branch September 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@michael-hawker michael-hawker Awaiting requested review from michael-hawker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niels9001 @michael-hawker @Arlodotexe