StyleCop.Analyzers

[GeorgeLeithead]

Hi all,

If not already discussed, could I suggest that we add StyleCop.Analyzers to the various projects to encourage rule compliance, like with .editorconfig? Some rules are always going to be contentious (such as "SA1101: Prefix local calls with this", which can be configured to alert 'none').

[pictos]

We had that discussion internally before, in the XCT era, and we didn't want to do that. If I'm not wrong, was because the .editorconfig provide us with all rules that we need and we don't want to scare any new contributor. This project has the goal to be the first project for people that want to contribute to open source, even the junior level

[pictos]

I would say it's something on your end. None of the core members had this issues and you're the first contributor that raise it up. If it's possible, can you try to run our project using a clean IDE version? (on VS we have the SafeMode and PresentationMode that doesn't use any extension or custom configuration)

[bijington]

So I am hoping that as part of the GravatarImageSource PR I can play with the .editorconfig settings and see how to improve the experience. I suspect that you have a number of settings on your machine that are different from the defaults whereas our settings are mostly the defaults and are not explicitly defined

[GeorgeLeithead]

Almost certainly true that I have some setting or extension difference. The trouble is, that so will many, many prospective contributors. Be that personal preferences, company standards, extensions, settings, etc.

I think therefore, the only way to enforce specific standards for any project, they need to be part of THAT project. Otherwise it'll become painful (has been a bit for myself) for new contributors and possibly turn them off.

[bijington]

Yes I agree, hopefully I can turn on all the defaults in .editorconfig and we should be good but I will have a play in the week and try applying to the GravatarImageSource PR

[TheCodeTraveler]

Thanks Shaun + George!!

Just to ensure this link doesn't get lost in the previous conversation on the AvatarView PR, here is the StyleCop rules that I pointed George to in order to keep methods/properties/fields etc organized inside of each class: https://stackoverflow.com/a/310967/5953643

[CliffAgius]

Closed as per the Community Stand-up discussion here: https://youtu.be/N9wMcBP4jtg?t=2889