[Closed] Rename EqualsConverter + NotEqualsConverter to IsEqualConverter + IsNotEqualConverter

[brminnick]

Currently EqualsConverter and NotEqualsConverter are the only converters in CommunityToolkit.Maui that return a bool and do not begin with Is*.

CommunityToolkit.Maui includes the following converters which all return a bool and begin with Is*:

• IsListNotNullOrEmptyConverter
• IsListNullOrEmptyConverter
• IsStringNotNullOrEmptyConverter
• IsStringNotNullOrWhiteSpaceConverter
• IsStringNullOrEmptyConverter
• IsStringNullOrWhiteSpaceConverter

I propose that we update the following converters to match the existing naming schema and improve discoverability:

• Rename EqualsConverter to IsEqualConverter
• Rename NotEqualsConverter to IsNotEqualConverter

[VladislavAntonyuk]

as for the file name. some of them end with shared. some of them not:
should we also be consistent with the filename?

[brminnick]

Also a good catch! We should fix that too 💯

I wonder if @pictos knows of a way to have an analyzer create a compiler error any time a file is missing a suffix?

E.g. Valid: *.shared.cs, *.macios.cs, *.android.cs etc
E.g. Invalid: *.cs

[VladislavAntonyuk]

#315

[pictos]

I could take a look, but I'm 80% sure that Roslyn analyzers can verify the file name

[brminnick]

Nice! I opened Discussion #316 for the file name validation 🙌

[CliffAgius]

Closed as answered