Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refund after vesting has passed #5

Open
sembrestels opened this issue Oct 26, 2021 · 0 comments
Open

Fix refund after vesting has passed #5

sembrestels opened this issue Oct 26, 2021 · 0 comments
Labels
bug Something isn't working Sohkai's review

Comments

@sembrestels
Copy link
Contributor

From Sohkai's review: _refund() should check if the vesting's cliff date has been reached when calculating the amount to burn: because refund() can be called at any time, a user who waits until after the cliff period to be refunded may experience odd behaviour (either they receive some vested tokens or are unable to process the refund because the token manager fails to burn the expected amount of tokens)
@sembrestels sembrestels added Sohkai's review bug Something isn't working labels Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Sohkai's review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sembrestels