Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Biomes! Core/Caverns shell and chitin armor values #3563

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

Sirderpsalot0357
Copy link
Contributor

@Sirderpsalot0357 Sirderpsalot0357 commented Nov 20, 2024

Additions

None

Changes

Change chitin and shell parent to ResourceBase instead of LeatherBase and remove Leathery tag so chitin and shell can't be used for the same things as leather (i.e. clothing).

References

None

Reasoning

The shells and chitins added in Biomes! Core and Caverns are treated as type of leather which means you can make clothing out of them. The problem is that they have really high sharp resistance that makes any clothing out of them kind of ridiculous. To use a duster as an example, a hyperweave version gives 5 mm of armor and a molluskshell version gives 6.5 mm of armor. The chitin armor sets from the Caverns mod seem inconsistent with this and only gives 3.9 mm at most.

Alternatives

Lowered the armor values of the various shells and chitins added in Biomes! Core and Biomes! Caverns by a factor of 10 and increased the stuff multiplier for the chitin armor sets to compensate so they should end up with the same values.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (30 days after tribal start)

Decrease shell and chitin armor values and increase stuff multiplier for chitin armor to compensate.
Lower armor values for shells and chitin.
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11927689751.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 20, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11927869469.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11927879214.zip

@Sirderpsalot0357 Sirderpsalot0357 marked this pull request as ready for review November 20, 2024 08:08
@N7Huntsman
Copy link
Contributor

While I agree it's somewhat odd that the materials are classed as leather, we're probably better off changing the category of the material from leather to something else rather than swinging the stats so wildly.

With these new stats, I'm concerned that any of the stuffable clothing made with anything other than this chitin is going to be extremely strong, and the chitin itself is extremely weak; weak chitin is barely better than patch leather and royal chitin offers less protection than bear leather.

@Sirderpsalot0357
Copy link
Contributor Author

Yeah, I was thinking that might be a better solution but wasn't sure if changing how the chitin is categorized would be outside the scope of a patch or something like that since it seems like it'd be more involved than just changing armor values. I think I might have figured out how to categorize it differently though.

@Sirderpsalot0357 Sirderpsalot0357 marked this pull request as draft November 21, 2024 08:04
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11949234782.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11949263135.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11949293749.zip

@Sirderpsalot0357 Sirderpsalot0357 marked this pull request as ready for review November 21, 2024 09:54
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12061090116.zip

N7Huntsman
N7Huntsman previously approved these changes Nov 28, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some initial confusion on my part as to how the stats for these types of chitin compared to other mods, I had the chance to sit down and make a balance pass that doesn't require us changing the stuff category.

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12061287895.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12061328727.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12061604110.zip

@N7Huntsman N7Huntsman merged commit 662e7ad into CombatExtended-Continued:Development Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants