Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error pops out when repairing the game #17

Closed
DarkXonline opened this issue Sep 9, 2022 · 6 comments
Closed

Error pops out when repairing the game #17

DarkXonline opened this issue Sep 9, 2022 · 6 comments
Labels
Area: Hi3Helper.Http Issue labeled for Hi3Helper.Http submodule issue releated Bug Something isn't working Fixed Issue has been fixed

Comments

@DarkXonline
Copy link

DarkXonline commented Sep 9, 2022

image

System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'from')
   at System.Net.Http.Headers.RangeItemHeaderValue..ctor(Nullable`1 from, Nullable`1 to)
   at System.Net.Http.Headers.RangeHeaderValue..ctor(Nullable`1 from, Nullable`1 to)
   at Hi3Helper.Http.Http.GetSession(SessionAttribute Session) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Session.cs:line 20
   at Hi3Helper.Http.Http.RetryableTaskContainer(SessionAttribute Session, Boolean IsMultisession) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 70
   at Hi3Helper.Http.Http.StartRetryableTask(SessionAttribute Session, Boolean IsMultisession) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 84
   at Hi3Helper.Http.Http.TryAwaitOrDisposeStreamWhileFail(Task InnerTask, SessionAttribute Session) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 115
 ---> System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter 'from')
   at System.Net.Http.Headers.RangeItemHeaderValue..ctor(Nullable`1 from, Nullable`1 to)
   at System.Net.Http.Headers.RangeHeaderValue..ctor(Nullable`1 from, Nullable`1 to)
   at Hi3Helper.Http.Http.GetSession(SessionAttribute Session) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Session.cs:line 20
   at Hi3Helper.Http.Http.RetryableTaskContainer(SessionAttribute Session, Boolean IsMultisession) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 70
   at Hi3Helper.Http.Http.StartRetryableTask(SessionAttribute Session, Boolean IsMultisession) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 84
   at Hi3Helper.Http.Http.TryAwaitOrDisposeStreamWhileFail(Task InnerTask, SessionAttribute Session) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 115
   --- End of inner exception stack trace ---
   at Hi3Helper.Http.Http.TryAwaitOrDisposeStreamWhileFail(Task InnerTask, SessionAttribute Session) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Class\Thread.cs:line 128
   at Hi3Helper.Http.Http.DownloadStream(String URL, Stream OutStream, CancellationToken Token, Int64 Start, Nullable`1 End) in C:\myGit\CollapseLauncher-fix20220825\Hi3HelperCore.Http\Http.cs:line 49
   at CollapseLauncher.Pages.RepairPage.RepairBlockFiles(FilePropertiesRemote input) in C:\myGit\CollapseLauncher-fix20220825\CollapseLauncher\Classes\RepairManagement\DataRepair.cs:line 158
   at CollapseLauncher.Pages.RepairPage.CategorizeRepairAction() in C:\myGit\CollapseLauncher-fix20220825\CollapseLauncher\Classes\RepairManagement\DataRepair.cs:line 64
   at CollapseLauncher.Pages.RepairPage.StartGameRepair(Object sender, RoutedEventArgs e) in C:\myGit\CollapseLauncher-fix20220825\CollapseLauncher\Classes\RepairManagement\DataRepair.cs:line 31```
@neon-nyan
Copy link
Member

neon-nyan commented Sep 10, 2022

Seems like this is an issue with the Hi3Helper.Http submodule. I will look into that later because I'm currently away now and will be back on Sept 11th.

Anyway, thank you for reporting this

@neon-nyan
Copy link
Member

neon-nyan commented Sep 11, 2022

I just investigated the issue and turns out, the issue was caused by the EndOffset by this piece of code in Hi3Helper.Http submodule:

https://github.com/neon-nyan/Hi3Helper.Http/blob/5e9e8d2d583b78db3127a0934fa7b18ccd14b623/Class/Session.cs#L20

The EndOffset is not checked while getting set to -1 and leave it as is. Instead, it will give the value -2 and causing invalid range.
image
Anyway, I'm planning to make a hotfix for this later or as soon as possible so,... wait for it while I'm trying to make a fix for this 😃

@neon-nyan neon-nyan added Bug Something isn't working Area: Hi3Helper.Http Issue labeled for Hi3Helper.Http submodule issue releated labels Sep 11, 2022
@neon-nyan
Copy link
Member

neon-nyan commented Sep 11, 2022

Update

This issue should've been fixed on the new 1.0.36.3-Hotfix update.
Please update your launcher to fix this issue and you can consider close this issue if you feel it has been solved.

Note: If there's no any response/reply, I will consider this issue has been fully fixed and close this issue within 24 hours.

Once again, thank you for reporting this.

@neon-nyan neon-nyan added the Fixed Issue has been fixed label Sep 11, 2022
@DarkXonline
Copy link
Author

Where is the 1.0.36.3-Hotfix update? I would like to try it out
Couldn't find it on Release
image

@neon-nyan
Copy link
Member

neon-nyan commented Sep 11, 2022

@DarkXonline the update on GitHub page hasn't been published.
You can do update inside of the launcher.

Go to App Settings menu -> Scroll down and click Check Update button
image

@DarkXonline
Copy link
Author

DarkXonline commented Sep 11, 2022

@DarkXonline the update on GitHub page hasn't been published. You can do update inside of the launcher.

Go to App Settings menu -> Scroll down and click Check Update button image

I see, I will update now :D
Edit: Updated and this fixed the issue, Thank you so much!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Hi3Helper.Http Issue labeled for Hi3Helper.Http submodule issue releated Bug Something isn't working Fixed Issue has been fixed
Projects
None yet
Development

No branches or pull requests

2 participants