Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tool presets don't respect sticky form #73

Closed
dranii opened this issue Nov 26, 2014 · 6 comments
Closed

Group tool presets don't respect sticky form #73

dranii opened this issue Nov 26, 2014 · 6 comments
Labels

Comments

@dranii
Copy link

dranii commented Nov 26, 2014

After filling up Group name and Description, if we hit save, things are saved without any way to go to
Tools tab. If Tools tab has "Group tool presets" preset there is no way to reach it again.

Ideally below Edit group > Profile there should be "Next" button instead of Save.
Cannot use unless this is fixed.

Also see AU-Landing-Project/au_group_notices#1

@jeabakker jeabakker changed the title Bug : Users are unable to use "presets" set by Group tool presets FR : Users are unable to use "presets" set by Group tool presets Nov 26, 2014
@jeabakker
Copy link
Member

This is not a bug, but a feature request.

If you click on save you wish to save. Maybe for usability it would be better if there was a next button, but it won't stop the plugin from working. So I changed this to a feature request

@dranii
Copy link
Author

dranii commented Nov 26, 2014

It does not save data that has been entered, instead returns the form - thus the plugin cannot work as intended.

@jeabakker
Copy link
Member

Maybe I dont understand you correctly?

When creating a group there are 3 tabs (profile, access and tools). All these tabs are part of 1 form, so clicking on save will save all the data across the 3 tabs.

Only during creation can a user select a group tool preset (as it says on the configuration page of the group tool presets)

When you edit an existing group there are 4 tabs (profile, access, tools and other). the first 3 are still part of the same form so when you click on save all data across all 3 tabs is saved.

The next button would be nice to have to help guide the user to the other tabs going from Profile -> access -> tools. But the plugin works fine without the next button.

@dranii
Copy link
Author

dranii commented Nov 26, 2014

Please login as a new end-user and follow the steps as in diagram
https://cloud.githubusercontent.com/assets/9887635/5205828/d16fe738-75c0-11e4-9773-534616f0c2d7.PNG
So, imho, I think that "save" button under "Tools" ( and ??also Access) should remain ghosted (with a small information message that name has to be filled up first) unless the Name, Description etc have been already filled up.

@jeabakker
Copy link
Member

I understand now, yes it's a bug. Thank you for reporting

@jeabakker jeabakker changed the title FR : Users are unable to use "presets" set by Group tool presets Group tool presets don't respect sticky form Nov 27, 2014
@jdalsem
Copy link
Member

jdalsem commented Dec 17, 2014

This is in fact a core issue Elgg/Elgg#7699. When that is fixed, we will also fix it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants