Optimised multi-stage docker build for cogstacksystems/medcat-trainer
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimised multi-stage docker build for `cogstacksystems/medcat-trainer` - Reduces uncompressed docker image size from 7.71GB to 6.13GB through - Separate stage for building frontend - Disable pip cache - Copy only required folders/files - Run container as non-root - Fix path to manage.py in run.sh Tested and working with docker-compose.yml with `cogstacksystems/medcat-trainer-nginx:v2.6.0` and `solr:8`.
|
hi @vvcb - thanks for the contribution here. I tried building and running locally: when I navigate to http://localhost:8001/ - the UI doesn't come up, /admin/ does appear though. Also on the api container - can we still have vim installed? I've found it handy in a pinch |
tomolopolis
requested changes
May 11, 2023
| FROM python:3.10 | ||
|
|
||
| # Update and upgrade everything | ||
| RUN apt-get -y update && \ |
There was a problem hiding this comment.
if we could include a vim install for container / image debugging
| ARG SPACY_MODELS="en_core_web_md" | ||
| RUN for SPACY_MODEL in ${SPACY_MODELS}; do python -m spacy download ${SPACY_MODEL}; done | ||
| RUN pip install pip --upgrade --no-cache-dir \ |
There was a problem hiding this comment.
nice with --no-cache-dir , makes sense to add
| @@ -14,7 +14,7 @@ echo "from django.contrib.auth import get_user_model | |||
| User = get_user_model() | |||
| if User.objects.count() == 0: | |||
| User.objects.create_superuser('admin', '[email protected]', 'admin') | |||
| " | python manage.py shell | |||
| " | python /home/api/manage.py shell | |||
|
|
|||
| if [ $LOAD_EXAMPLES ]; then | |||
| python /home/load_examples.py & | |||
There was a problem hiding this comment.
I think WORKDIR used to be in /home/api so running python manage.py would have relative path serving up the static content directly for container available debugging purposes.
tomolopolis
requested changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimised multi-stage docker build for
cogstacksystems/medcat-traineras described in detail in comments in response to #92.cogstacksystems/medcat-trainer:v2.6.0from 7.71GB to 6.13GBdistfolder that is the output ofnpm buildpip install --no-cache-dirto save >900MBTested and working with docker-compose.yml with
cogstacksystems/medcat-trainer-nginx:v2.6.0andsolr:8(with defaultcdb.datandvocab.dat).