Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with discord.py v2.0 #98

Closed
FightMan01 opened this issue Aug 3, 2021 · 3 comments · Fixed by #122
Closed

Does not work with discord.py v2.0 #98

FightMan01 opened this issue Aug 3, 2021 · 3 comments · Fixed by #122
Assignees

Comments

@FightMan01
Copy link

Discord.py v2 removes the on_socket_response event so the library won't work. Instead we will have the on_raw_socket_receive event.

@Jackenmen
Copy link
Member

Red-Lavalink will not work with d.py 2.0 until it is actually released and until Red also supports it.

I'll keep this open for now though since it does contain helpful information and we will have to work on this eventually, thanks!

@FightMan01
Copy link
Author

Well, I thought it :D I'm working on a solution unfortunately I can't decompress the binary data. If I figure out the solution, I will open a PR.
Also this commit can be helpful: Rapptz/discord.py@e2250d4

@Jackenmen
Copy link
Member

We'll probably switch to VoiceProtocol rather than use on_raw_socket_receive, see #97.

Sadly, on_socket_event_type isn't useful for our case so the VoiceProtocol is probably the best we'll be able to do without hurting performance by doing zlib decompression on all events. I say "sadly" because it will take some effort to migrate to that interface, but in the long run, it would be good for us to use it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants