Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Keys in AlphaTex #875

Closed
Danielku15 opened this issue May 25, 2022 Discussed in #853 · 0 comments · Fixed by #880
Closed

Minor Keys in AlphaTex #875

Danielku15 opened this issue May 25, 2022 Discussed in #853 · 0 comments · Fixed by #880
Labels
area-file-formats Related to supported file formats file-format-alphaTex Related to the built-in language alphaTex platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀

Comments

@Danielku15
Copy link
Member

Discussed in #853

Originally posted by jonaro00 May 15, 2022

Proposed feature

AlphaTex currently allows defining major key signatures with \ks G. I propose also allowing minor keys by simply expanding the switch-cases in AlphaTexImporter.parseKeySignature.

What the syntax would be is up for discussion. My idea is to keep the default behavior for major keys, using \ks Eminor for minor, but also allowing \ks Gmajor for consistency.

The switch-case would then look like:

...
case 'g':
case 'gmajor':
case 'eminor':
    ...
```</div>
@Danielku15 Danielku15 added file-format-alphaTex Related to the built-in language alphaTex type-improvement 🚀 area-file-formats Related to supported file formats state-accepted This is a valid topic to work on. platform-all Affects all platforms labels May 25, 2022
@jonaro00 jonaro00 mentioned this issue May 25, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-file-formats Related to supported file formats file-format-alphaTex Related to the built-in language alphaTex platform-all Affects all platforms state-accepted This is a valid topic to work on. type-improvement 🚀
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant