Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create native Android integration #532

Closed
Danielku15 opened this issue Jan 17, 2021 · 2 comments · Fixed by #612
Closed

Create native Android integration #532

Danielku15 opened this issue Jan 17, 2021 · 2 comments · Fixed by #612
Assignees
Labels
platform-android Related to the Android specific integrations type-feature 💡

Comments

@Danielku15
Copy link
Member

Once we have the base code translated to Kotlin the next level is build proper native android controls for integration into apps.

@Danielku15 Danielku15 self-assigned this Jan 17, 2021
@Danielku15 Danielku15 added the platform-android Related to the Android specific integrations label Jan 17, 2021
@lannka
Copy link

lannka commented Apr 3, 2021

To keep the core repo clean and slim, have you thought about moving those different integrations (Android, .Net) into separate repos? Or do you feel there will be too much dependencies and boilerplate that can slow you down too much?

@Danielku15
Copy link
Member Author

I have thought of this but it does not make a lot sense. Here my thoughts on that

  1. The platform specific integrations are typically quite slim from the amount of code they add to the repo. My goal is rather to port the C#/Kotlin specific parts over to TypeScript too, and then rely fully on transpiling.

  2. The main part of the library still is living here and is based on transpiling. Usually there is the base/core library and then the platform specific controls on top. I could pull the main repo as submodule and run transpiling there but this would then just be a shift of the CI/CD to a different repo, there is not any real gain on this but rather effort to get it running clean.

  3. The only thing I want to maybe move out, and also extend are the samples. They are not needed for development of alphaTab itself and rather hidden/confusing for integrators the way they are today.

In short: A split into a polyrepo will just generate effort, and make the whole development chain more complicated.

@Danielku15 Danielku15 modified the milestone: [v1.3.0] Native Android Support Nov 4, 2021
@Danielku15 Danielku15 moved this to Done in Version 1.3 Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-android Related to the Android specific integrations type-feature 💡
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants