-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PRF Changes #409
PRF Changes #409
Conversation
…emove the page templates tab [ref Codeinwp/templates-cloud#91]
message, | ||
ok: () => { | ||
const input = document.getElementById( `tpc-${ node }` ); | ||
const title = input.value || 'Template'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have this default value as a translatable string via window.tiTpc.exporter
?
window.tiTpc.postType | ||
) && | ||
parseInt( window.tiTpc.tier ) === 3 && ( | ||
{ window.tiTpc.postTypes.includes(window.tiTpc.postType) && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion here: you can declare this as a constant outside the component with a name like isPostTypeCompatible
to highlight the compatibility check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 . I left some small suggestions.
@abaicus TC was also included in Otter Agency, can we also include that? |
@ineagu It should work with all previously included licenses. It uses the same license mechanism we previously did on TPC so nothing should be different. |
🎉 This PR is included in version 1.2.14 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Page templates
tab inside the Template cloud inserter modal;Will affect visual aspect of the product
YES (but only on the backend)
Test instructions
Check before Pull Request is ready:
Closes Codeinwp/templates-cloud#91.