Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRF Changes #409

Merged
merged 12 commits into from
Nov 28, 2024
Merged

PRF Changes #409

merged 12 commits into from
Nov 28, 2024

Conversation

abaicus
Copy link
Collaborator

@abaicus abaicus commented Nov 26, 2024

Summary

  • Changes plugin name;
  • Deprecates the old Page templates tab inside the Template cloud inserter modal;
  • Now, only users with a valid library license can see the block/elementor/beaver functionalities;
  • Valid licenses are either Template Cloud dedicated ones, or Neve licenses from tier 3;
  • Migrates old users to the new experience, depending on the active license, and conditioned by the templates they previously had saved in the cloud according to this comment here.

Will affect visual aspect of the product

YES (but only on the backend)

Test instructions

Arc 2024-11-25 15 44 30

Check before Pull Request is ready:

Closes Codeinwp/templates-cloud#91.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Nov 26, 2024
@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 26, 2024

Plugin build for dac8bf1 is ready 🛎️!

message,
ok: () => {
const input = document.getElementById( `tpc-${ node }` );
const title = input.value || 'Template';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also have this default value as a translatable string via window.tiTpc.exporter?

window.tiTpc.postType
) &&
parseInt( window.tiTpc.tier ) === 3 && (
{ window.tiTpc.postTypes.includes(window.tiTpc.postType) && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion here: you can declare this as a constant outside the component with a name like isPostTypeCompatible to highlight the compatibility check.

Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 . I left some small suggestions.

@ineagu
Copy link
Contributor

ineagu commented Nov 27, 2024

@abaicus TC was also included in Otter Agency, can we also include that?

@abaicus
Copy link
Collaborator Author

abaicus commented Nov 27, 2024

@ineagu It should work with all previously included licenses. It uses the same license mechanism we previously did on TPC so nothing should be different.

@ineagu
Copy link
Contributor

ineagu commented Nov 27, 2024

As a new user, after plugin activation, I still see the menu item for Templates Cloud, once I click on it or somewhere else, it goes away.
Screenshot 2024-11-27 at 12 54 16

@abaicus

@abaicus abaicus merged commit f20d679 into development Nov 28, 2024
6 of 7 checks passed
@abaicus abaicus deleted the prf branch November 28, 2024 14:31
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 1.2.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants