Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare the plugin for localization #2375

Closed
stefan-cotitosu opened this issue Sep 16, 2024 · 0 comments · Fixed by #2401
Closed

Prepare the plugin for localization #2375

stefan-cotitosu opened this issue Sep 16, 2024 · 0 comments · Fixed by #2401
Assignees
@Soare-Robert-Daniel
Labels
new feature Request for a new feature or functionality to be added to the project.

Comments

@stefan-cotitosu
Copy link

stefan-cotitosu commented Sep 16, 2024 •
edited
Loading

What problem does this address?

We decided to translate the plugin to German and to achieve this, the following changes need to be applied to the code.

What is your proposed solution?

Localize all the strings

  • Review all the strings within the PHP and JS files of the plugin to make sure they are fully localized and not hardcoded
  • Implement the PHPCS sniff to check for translator comments in the code. Rule to be added: WordPress.WP.I18n.MissingTranslatorsComment

Translate the Formbricks Survey

Reference: Codeinwp/neve@cb3ec00

Will this feature require documentation? (Optional)

No.
@stefan-cotitosu stefan-cotitosu added the new feature Request for a new feature or functionality to be added to the project. label Sep 16, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Oct 7, 2024 that will close this issue
fix: string translation #2401
Merged
9 tasks
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Oct 31, 2024
Merged
9 tasks
@selul selul closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
new feature Request for a new feature or functionality to be added to the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: string translation Codeinwp/otter-blocks
3 participants
@selul @Soare-Robert-Daniel @stefan-cotitosu