Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar height not same as on Tablet and Desktop #1776

Closed
mghenciu opened this issue Jul 24, 2023 · 3 comments · Fixed by #1814
Closed

Progress Bar height not same as on Tablet and Desktop #1776

mghenciu opened this issue Jul 24, 2023 · 3 comments · Fixed by #1814
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Milestone

Comments

@mghenciu
Copy link
Contributor

mghenciu commented Jul 24, 2023

Description

As reported also here,

Progress Bar block doesn't respect the set Height on Mobile.
In the example below it set to 13px, but on Mobile frontend is 30px.

I think this should be included on the Visual regression test list.

Step-by-step reproduction instructions

  1. Create a fresh Otter Version 2.3.2 + Neve instance
  2. Add the Blocks from below on a page
  3. Preview the page on Desktop vs Mobile
  4. Notice that on Mobile, instead of 13px height - the progress bar has 30px

blocks-export.json.zip

Screenshots, screen recording, code snippet or Help Scout ticket

Screenshot 2023-07-24 at 12 56 24
Screenshot 2023-07-24 at 12 56 44

Environment info

No response

Is the issue you are reporting a regression

No

@mghenciu mghenciu added the bug This label could be used to identify issues that are caused by a defect in the product. label Jul 24, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel added the tiny (1h) - This label is used for issues that can be completed in under an hour. label Jul 28, 2023
@Soare-Robert-Daniel
Copy link
Contributor

@HardeepAsrani I remember correctly; this was one because we did not have multiple versions of the height based on the viewport, so we decided to make the mobile version have a fixed width.

Here is how it looks when restrictions are removed.

image

@HardeepAsrani
Copy link
Member

@Soare-Robert-Daniel I don't see any issues of using the same height on all devices instead of a fixed. Let me know if you think that can cause any other issues.

@pirate-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HardeepAsrani HardeepAsrani added this to the 2.3.4 milestone Aug 23, 2023
@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product. tiny (1h) - This label is used for issues that can be completed in under an hour.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants