-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images Inside <header> Element Do Not Lazy Load #863
Comments
@kushh23 thats expected, images in header and above the fold and they dont need to be lazyloaded. Let me know if Im missing something |
@selul, this makes sense, but I can see an issue with the fact that we don't do the scaling either, but at the same time, we remove the responsive sizes for those elements. So if we have a 1000x1000 image in header, it would load at this size, right? Even on mobile. |
@ineagu do you see the sizes being removed on Kush case ? |
@selul I haven't seen those sizes there from srcset, but they are not usually added to the logo as far as I can see :
|
@kushh23 I will be closing this since the behaviour is expected to work like this. |
Description
A user reported that there is a bug where images placed inside a
<header>
element are not lazy-loaded, and this issue impacts the scaling behavior of other pictures on the page.<header>
element are lazy-loaded and scaled appropriately.<header>
element prevents it from being lazy-loaded or scaled.<header>
causes the previously correctly scaled image outside the<header>
to stop scaling as well.I am able to replicate the first two steps easily, but their third point do not exist at my end, on my end, if I use same image then it is lazyloaded outside header element too.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet or Help Scout ticket
Reported here - https://secure.helpscout.net/conversation/2764612077/441276
Can be checked here - https://verdantfarmer.s1-tastewp.com/test/
Images provided by user:
Environment info
No response
Is the issue you are reporting a regression
No
The text was updated successfully, but these errors were encountered: