Accent color does not show up in default style thumbnail (wp repo)

[JohnPixle]

We should investigate this a bit deeper I believe. Despite the fact that the default blue accent color shows in the editor, it's not visible in the default thumbnail preview. Thanks!

[JohnPixle]

Adding some more context here.

After a discussion with Hardeep on Slack, this seems to be related to the fact that in the default theme.json file we use color variables. This approach was followed in oder to migrate colors from Neve Classic, and the implementation was done by Bogdan.

"color": {
      "palette": [
        {
          "slug": "ti-bg",
          "color": "var(--nv-site-bg, #FFFFFF)",

Hardeep suggested to wait for Bogdan to return in order to get more insights on this, and I agreed.
In my opinion we should evaluate the overall effectiveness of the Neve Classic > Neve FSE migration, and see if it makes sense to revert from using variables (if indeed they cause such major problems).

It is quite important in my opinion to be able to properly display the theme style presets both in the context of the theme repo and the site settings.

Additional issues with Fonts Family preview in thumbnails

@HardeepAsrani Turns out there are more issues inside the Site editor, regarding the previews of the font families in the theme styles. I am not sure if they are also caused by the use of (color or typographic) variables.

I do not see anything wrong in the json files, if you want to confirm, this is the folder with the style presets for Neve FSE:
https://github.com/Codeinwp/neve-fse/tree/main/styles

Our other FSE themes do not have this issue.

Here is a loom overview:
https://www.loom.com/share/7442b1555fcb4dbc926a23178deba1a1?sid=060e7862-e5f0-4fd1-8c5a-2a9ec50cb76f

@mghenciu just keeping you in the loop about this.

[JohnPixle]

@HardeepAsrani Hey, regarding the release, I think the only thing left is for you to look into the Font Family previews and let me know if there is something we can do about it, or if it is related to the variables as well. Feel free to refer to the video above.

Let me know, thanks!

[HardeepAsrani]

@JohnPixle As we discussed this few days back in Slack, let me know if there's anything else that can be done here.

[JohnPixle]

@HardeepAsrani Hey! I do'nt think there is anything else we can do here for now. Thanks for looking into it however!!