New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie not compatible with symfony/browser-kit #24

Open

hinablue opened this issue May 30, 2022 · 1 comment

Contributor

hinablue commented May 30, 2022

In the old version of symfony/browser-kit, the Cookie's __construct is

public function __construct(string $name, ?string $value, string $expires = null, string $path = null, string $domain = '', bool $secure = false, bool $httponly = true, bool $encodedValue = false, string $samesite = null) { ... }

And in the Phalcon4, using cookie set with expires is only allow integer, so there will be TypeError when running the test.

[TypeError] Argument 3 passed to Symfony\Component\BrowserKit\Cookie::__construct() must be of the type string or null, int given, called in /root/.composer/vendor/codeception/module-phalcon4/src/Codeception/Lib/Connector/Phalcon4.php on line 156

Maybe convert the timestamp to UTC String for old symfony/browser-kit?

The text was updated successfully, but these errors were encountered:

Contributor Author

hinablue commented May 30, 2022

Oops. I saw the master maybe fixed. But v1.0.7 is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment