Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue/4059 #4071

Merged
merged 2 commits into from
Mar 24, 2017
Merged

Fixed Issue/4059 #4071

merged 2 commits into from
Mar 24, 2017

Conversation

Naktibalda
Copy link
Member

Run the last statement in dump file even if it doesn't end with delimiter

Fixes #4059

@DavertMik
Copy link
Member

DavertMik commented Mar 23, 2017 •
edited
Loading

I restarted the build on Semaphore few times but it is still failing :(

I don't know how it is related but the issue is:

1) WebDriverTest: Session snapshots
 Test  tests/web/WebDriverTest.php:testSessionSnapshots
                                                                                                                                                                                                                                                             
  [PHPUnit_Framework_Exception] Argument 1 passed to Codeception\Module\WebDriver::cookieDomainMatchesConfigUrl() must be of the type array, object given, called in /home/runner/Codeception/src/Codeception/Module/WebDriver.php on line 2721 and defined

@DavertMik
Copy link
Member

I think this is related #4073

@DavertMik
Copy link
Member

The WebDriver failure turned out to be unrelated so I'm merging

@DavertMik DavertMik merged commit eeeae37 into Codeception:2.2 Mar 24, 2017
@Naktibalda Naktibalda deleted the issue/4059 branch April 17, 2017 18:26
chris1312 pushed a commit to chris1312/Codeception that referenced this pull request Jun 16, 2017
@Naktibalda
Fixed Issue/4059 (Codeception#4071)
c088c4b 
* [Db] Run the last statement in file even if it doesn't end with delimiter

Fixes Codeception#4059

* Eliminated property sqltoRun
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naktibalda @DavertMik