Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small refactoring issue #4000

Merged
merged 2 commits into from
Feb 7, 2017
Merged

Fix small refactoring issue #4000

merged 2 commits into from
Feb 7, 2017

Conversation

lcobucci
Copy link
Contributor

@lcobucci lcobucci commented Feb 6, 2017 •
edited
Loading

On ed549a9 an else statement was removed (awesome) but the author forgot to interrupt the execution flow and that is causing our test suite to fail 😭 but this fixes it.

Fixes #4001

@lcobucci
Fix small refactoring issue
393b29c 
On ed549a9 an `else` statement was
removed (awesome) but the author forgot to interrupt the execution
flow and that is causing our test suite to fail 😭 but this fixes
it.
@lcobucci
Copy link
Contributor Author

lcobucci commented Feb 6, 2017 •
edited
Loading

The sad thing is that this issue wasn't detected by your test suite and since I'm not familiar with the codebase I don't know how can I help you to make sure this won't happen again...

@DavertMik DavertMik mentioned this pull request Feb 7, 2017
Closed
@DavertMik
Copy link
Member

The sad thing is that this issue wasn't detected by your test suite and since I'm not familiar with the codebase I don't know how can I help you to make sure this won't happen again...

Yes, that's really sad (
iframe was not tested properly. However, it is not that hard to make a regression test:

You need to start demo application
Create a web page with iframes in tests/data/app/form
Write a test at tests/web/WebDriverTest.php

@lcobucci
Copy link
Contributor Author

lcobucci commented Feb 7, 2017

@DavertMik tests added by @snoek09 (he was much faster than me 😄)

I think is now ready to go 😉

@Naktibalda Naktibalda merged commit 41a206e into Codeception:2.2 Feb 7, 2017
@DavertMik
Copy link
Member

Thank you @lcobucci and @snoek09
Awesome work!

@lcobucci lcobucci deleted the fix-webdriver-issue branch February 8, 2017 07:58
@lcobucci
Copy link
Contributor Author

lcobucci commented Feb 9, 2017

@DavertMik @Naktibalda any plan on releasing it?

@DavertMik DavertMik mentioned this pull request Mar 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcobucci @DavertMik @Naktibalda