Make the postgresql loader load $$ syntax correctly #1450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it to be impossible to import postgresql triggers made with the $$ syntax, so I fixed it.
To fix it I had to copy paste the entire loader code from the abstract Db driver and added some extra parsing logic. Perhaps there is a better way to fix it, and I'm open for input on that.
This is the SQL code that didn't work:
Without the fix I got this error in the testsuite
With the fix the SQL code gets imported without any problems.
Please let me know what you think!