This repository has been archived by the owner on Aug 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 123
Fix Trailing Slash Issue #254
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
const glob = require("glob-promise"); | ||
const path = require("path"); | ||
const fs = require("fs-extra"); | ||
|
||
// quick fix for GH pages trailing slash issues | ||
// /myDoc/index.html => /myDoc.html | ||
async function generateSimpleHtmlFiles(outDir) { | ||
console.log("generateSimpleHtmlFiles", outDir); | ||
|
||
const pattern = path.join(outDir, "/**/index.html"); | ||
// console.log('pattern', pattern); | ||
|
||
const filePaths = (await glob(pattern)).filter((filePath) => { | ||
return filePath !== path.join(outDir, "/index.html"); | ||
}); | ||
|
||
// console.log('filePaths', filePaths); | ||
|
||
await Promise.all( | ||
filePaths.map(async (filePath) => { | ||
if ((await fs.stat(filePath)).isDirectory()) { | ||
return; | ||
} | ||
// console.log(file); | ||
const filePathCopy = `${path.dirname(filePath)}.html`; | ||
if (await fs.pathExists(filePathCopy)) { | ||
// console.log(`Skipping ${filePathCopy}`); | ||
} else { | ||
await fs.copyFile(filePath, filePathCopy); | ||
// console.log(`Created ${filePathCopy}`); | ||
} | ||
}) | ||
); | ||
} | ||
|
||
module.exports = function () { | ||
console.log("site plugin"); | ||
return { | ||
plugin: "site-plugin", | ||
async postBuild(props) { | ||
await generateSimpleHtmlFiles(props.outDir); | ||
}, | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could change this to be a bit more specific? I feel like it might trip us up in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the file name too.