Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health master #115

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Health master #115

wants to merge 61 commits into from

Conversation

abzainuddin
Copy link
Contributor

No description provided.

robin and others added 30 commits February 25, 2021 00:19
Add clone method for models with the option to also clone the changes
5511f7e
Fix testing and parsing relations from copied model
fd1a2cc
@robinzelders
Merge pull request #1 from robinzelders/model-clone-method
b35271e 
Model clone method
add comments
598d11d
Merge branch 'model-clone-method'
9fd0a8d
Create new build
fe3bb5a
Fixed small bug
b087964
Add different way to notify store of changes
01e511d
add build
bbf1556
Copy a model returns a copy of the model when no model to copy is given
c259fa6
Add build
cbc7de0
Add new build number
1d2980a
Add check method to model that does a dry run save to check for valid…
aa2d4bb 
…ation errors

 Ref T30324
@robinzelders
Merge pull request #2 from robinzelders/T30324-model-validation
e007379 
Add check method to model that does a dry run save to check for valid…
Return request, so you can check if it was successful
309b726 
 Ref T30324
@robinzelders
Merge pull request #3 from robinzelders/T30324-model-validation
004e01a 
Return request, so you can check if it was successful
Proper way of adding header to model validation request
6bb69f8 
 Ref T30324
@robinzelders
Merge pull request #4 from robinzelders/T30324-model-validation
d9d0ead 
Proper way of adding header to model validation request
Proper way of adding header to model validation request
4bd6b17 
 Ref T30324
@robinzelders
Merge pull request #5 from robinzelders/T30324-model-validation
bb12f7c 
Proper way of adding header to model validation request
Fix relations setting
3797aad
Fix relations setting
d93c76f
@robinzelders
Merge pull request #6 from robinzelders/copy_fix_test
3ffd171 
Copy fix test
bump version
e46b198
Added fix for copy where related items are models instead of stores
dff07d0
revert file delete
8fd4c83
Fix copy changes double '__' instead of '_'
505b6c2
Also copy related objects of related objects that were not properly d…
96f203e 
…efined
Added warning for relations on related models that were not defined i…
c9636d2 
…n source model
Test using parseRelations function
2423512
robin and others added 29 commits March 31, 2021 22:49
Revert to previous implementation
e354afa
Also copy store changes
e3a6872
More tests for model copy and validation
5c934ce
Extra comments
661a8c4
@robinzelders
Merge branch 'master' into master
ed1abb3
Make isNew work for negative ids as well
22cb52e
Add build
53179ec
Add assignInternalId function as well as some tests
1e998e0
With build
433d312
bump version
6b99f8d
v0.28.2
ba6c8fc
Merge remote-tracking branch 'origin/isnew-for-negative-ids' into isn…
f32def8 
…ew-for-negative-ids
Add extra safety check for copying stores
57fb1a0
Move helpers file... oopsie my bad
10dfe76
Skip testing the helpers.js
2b14d91
v0.28.3
8f155f7
@stefanmajoor
Merge remote-tracking branch 'robin/isnew-for-negative-ids'
7af86a4
Add catch to validate
d7d7058
@daanvdk
Merge pull request #110 from robinzelders/isnew-for-negative-ids
6bb4ec6 
Add catch to validate
v0.28.4
bbdc5b8
Throw the caught error
28dffb9
@robinzelders
Merge branch 'health_master' into isnew-for-negative-ids
25a8744
@robinzelders
Merge pull request #111 from robinzelders/isnew-for-negative-ids
e866b78 
Throw caught error
@abzainuddin
Remove debug artifact
8a27546
Merge remote-tracking branch 'origin-cy/master' into health_master # …
594dda1 
…Conflicts: # src/Model.js # src/__tests__/Model.js
Merge with master fix
8d72cc2
@stefanmajoor
Merge branch 'master' into health_master
50be433
Merge remote-tracking branch 'origin/master' into health_master
bb59549 
# Conflicts:
#	dist/mobx-spine.cjs.js
#	dist/mobx-spine.es.js
#	src/__tests__/Model.js
Update health_master with latest master
0c57d21
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.65%. Comparing base (75725ac) to head (0c57d21).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
- Coverage   93.77%   93.65%   -0.13%     
==========================================
  Files           6        6              
  Lines         868      914      +46     
  Branches      204      223      +19     
==========================================
+ Hits          814      856      +42     
- Misses         44       48       +4     
  Partials       10       10
Files Coverage Δ
src/Model.js 91.30% <93.93%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75725ac...0c57d21. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abzainuddin @codecov-commenter @robinzelders @stefanmajoor @daanvdk