Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection reference in testing #3

Open
stam opened this issue Aug 11, 2017 · 0 comments
Open

Fix connection reference in testing #3

stam opened this issue Aug 11, 2017 · 0 comments

Comments

@stam
Copy link
Contributor

stam commented Aug 11, 2017

Because we create the connection instance inside the websocket listener, we have no clean way to access it in the tests.

We currently set the websocket.connection, but this is only possible if the websocket is mocked. Therefore the Connection.init contains test only code which is nasty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant