Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "refs" for CodeEditor #176

Open
jhmullen opened this issue Sep 21, 2017 · 1 comment
Open

Fix "refs" for CodeEditor #176

jhmullen opened this issue Sep 21, 2017 · 1 comment
Assignees
@jhmullen
Labels
priority: low type: enhancement

Comments

@jhmullen
Copy link
Collaborator

CodeEditor's iframe uses the deprecated this.refs for reference. Update this to use proper mapping.
@jhmullen jhmullen self-assigned this Sep 21, 2017
@jhmullen jhmullen added this to the Post November Beta milestone Sep 21, 2017
@davelandry davelandry removed this from the Post November Beta milestone Oct 31, 2017
@jhmullen jhmullen added this to the Post November Beta milestone Nov 2, 2017
@davelandry davelandry removed this from the Post November Beta milestone Nov 4, 2017
@alexandersimoes
Copy link
Contributor

This was a "nice to have" but not required. As a further explanation, React uses the ref prop as a means to access the underlying HTML node. It was not deprecated by the API has since changed in laters versions of React.

Updating Canon would potentially require the developer to address this issue, but in the current version of the source code, this is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhmullen jhmullen

Labels
priority: low type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexandersimoes @jhmullen @davelandry @kelvinfrade