Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use if SubscriptionManager is deprecated #4

Open
kkundanmal-nicejob opened this issue May 9, 2018 · 5 comments
Open

How to use if SubscriptionManager is deprecated #4

kkundanmal-nicejob opened this issue May 9, 2018 · 5 comments

Comments

@kkundanmal-nicejob
Copy link

kkundanmal-nicejob commented May 9, 2018

According to https://github.com/apollographql/graphql-subscriptions, the SubscriptionManager is deprecated.

It seems like subscriptions-transport-sse will not work without SubscriptionManager.

Is there any way to use subscriptions-transport-sse with the current version of Apollo's GraphQL subscriptions without SubscriptionManager?

@mrdulin
Copy link

mrdulin commented Sep 6, 2018

+1

@tgensol
Copy link

tgensol commented Jan 1, 2019

Any idea ?

@EdouardLauret
Copy link

there is a hook branch from the react-apollo develop branch : Hooks
I think you can inspire you from there to build your own useMutation/Subscription etc..

@Danny-Rosenblatt-Intrepid

I believe I am running into this as well, receiving "TypeError: _graphqlSubscriptions.SubscriptionManager is not a constructor" when I attempt to start my express server.

@TimSusa
Copy link

TimSusa commented May 30, 2019

Hey,

I would like you to consider the implementation from: https://github.com/GraphQLCollege/graphql-postgres-subscriptions/blob/master/event-emitter-to-async-iterator.js My bet is, we could get inspired from there to yield an up-to-date solution. The issue is, that we seem to be forced to use that Async Iterator stuff, which seems to us like critical code (could cause Mem-Leaks under special circumstances).

Anyhow, I would claim most people are using apollo-server-express atm so parts of the express.js could be consolidated with the approach from here: https://github.com/GraphQLCollege/graphql-postgres-subscriptions/blob/master/postgres-pubsub.js Maybe the rest of server implementation could be thrown away?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants