From 775c971d0c432b03175a44621ff1689a1496aadf Mon Sep 17 00:00:00 2001 From: seantokuzo Date: Fri, 31 May 2024 20:46:55 -0700 Subject: [PATCH 1/2] deleted old pr template and rename new one --- PULL_REQUEST_TEMPLATE_OLD.md | 31 ------------------- ...emplate_new.md => pull_request_template.md | 0 2 files changed, 31 deletions(-) delete mode 100644 PULL_REQUEST_TEMPLATE_OLD.md rename pull_request_template_new.md => pull_request_template.md (100%) diff --git a/PULL_REQUEST_TEMPLATE_OLD.md b/PULL_REQUEST_TEMPLATE_OLD.md deleted file mode 100644 index 12fc0ba..0000000 --- a/PULL_REQUEST_TEMPLATE_OLD.md +++ /dev/null @@ -1,31 +0,0 @@ -Thank you for your contribution to Code Hammers's repository! Before merging, please fill out this brief form. - -### Description - -(What does this PR do? What problem does it solve? What feature does it add? What is the impact of this change? What other PRs does this depend on? If this PR is a work in progress, please add the `WIP` label.) - -### Jira Task - -(**Replace this text** with a link to your Jira task link here, or N/A) - -### Testing Instructions - -_**Note:** this does not mean pasting in how to run the Jest tests. Let us know if there is a specific flow we need to follow to test the fuctionality on the site itself, or if there is a specific page you want to test, etc. This is not needed for most PRs._ - -### Checklist - -Please go through each item of this checklist carefully. - -- [x] (Example checked item. Don't add any spaces around the "x".) - -#### All Team Members - -- [ ] I added a descriptive title to this PR. -- [ ] I filled out the **Description**, **Jira Task**, and **Testing Instructions** sections above. -- [ ] I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc. -- [ ] I ran `npm run docker-test` in my local environment to check that this PR passes all unit tests. -- [ ] I did a quick check to make sure my code changes follow the recomended style guide. - -### Additional Notes, Images, etc. - -(This is space for any additional information or attachments you'd like to add as part of this PR.) diff --git a/pull_request_template_new.md b/pull_request_template.md similarity index 100% rename from pull_request_template_new.md rename to pull_request_template.md From 8e8bed8c7ad953a2a4ece8a9bf6289d9b1cf9c33 Mon Sep 17 00:00:00 2001 From: seantokuzo Date: Sat, 1 Jun 2024 12:12:46 -0700 Subject: [PATCH 2/2] replace pr template in /docs directory with new one - delete pr template from root directory --- docs/pull_request_template.md | 2 +- pull_request_template.md | 31 ------------------------------- 2 files changed, 1 insertion(+), 32 deletions(-) delete mode 100644 pull_request_template.md diff --git a/docs/pull_request_template.md b/docs/pull_request_template.md index 12fc0ba..c8fcffa 100644 --- a/docs/pull_request_template.md +++ b/docs/pull_request_template.md @@ -24,7 +24,7 @@ Please go through each item of this checklist carefully. - [ ] I filled out the **Description**, **Jira Task**, and **Testing Instructions** sections above. - [ ] I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc. - [ ] I ran `npm run docker-test` in my local environment to check that this PR passes all unit tests. -- [ ] I did a quick check to make sure my code changes follow the recomended style guide. +- [ ] I reviewed my code to make sure it follows the recommended style guide. ### Additional Notes, Images, etc. diff --git a/pull_request_template.md b/pull_request_template.md deleted file mode 100644 index c8fcffa..0000000 --- a/pull_request_template.md +++ /dev/null @@ -1,31 +0,0 @@ -Thank you for your contribution to Code Hammers's repository! Before merging, please fill out this brief form. - -### Description - -(What does this PR do? What problem does it solve? What feature does it add? What is the impact of this change? What other PRs does this depend on? If this PR is a work in progress, please add the `WIP` label.) - -### Jira Task - -(**Replace this text** with a link to your Jira task link here, or N/A) - -### Testing Instructions - -_**Note:** this does not mean pasting in how to run the Jest tests. Let us know if there is a specific flow we need to follow to test the fuctionality on the site itself, or if there is a specific page you want to test, etc. This is not needed for most PRs._ - -### Checklist - -Please go through each item of this checklist carefully. - -- [x] (Example checked item. Don't add any spaces around the "x".) - -#### All Team Members - -- [ ] I added a descriptive title to this PR. -- [ ] I filled out the **Description**, **Jira Task**, and **Testing Instructions** sections above. -- [ ] I added or updated [Jest unit tests]for any changes to components, server-side controllers, etc. -- [ ] I ran `npm run docker-test` in my local environment to check that this PR passes all unit tests. -- [ ] I reviewed my code to make sure it follows the recommended style guide. - -### Additional Notes, Images, etc. - -(This is space for any additional information or attachments you'd like to add as part of this PR.)