Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have a improvement for support Image display, I think this change can be merged ? #1263

Open
ximmyxiao opened this issue Feb 15, 2023 · 1 comment

Comments

@ximmyxiao
Copy link
Contributor

ximmyxiao commented Feb 15, 2023

In DTCoreText ,Each image tag need be specified a width and height value for display
width='344px' height='611.01243339254px'
If this width and height are not specified, the image will not display.

But in fact , many image will have width and height in url components like this(and without height&width specified as attributes):
<img src="https://km.woa.com/asset/966393bc0a7642088bf0242c32fae152?height=2532&amp;width=1170\">

So I make a small change to support this url .

Do you think this change is needed to be merged?

@odrobnik
Copy link
Collaborator

You are welcome to propose a change request with this. Sounds useful. But only if width and height isn't specified any other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants