When using use_modular_headers!, NSUInteger is cast in Swift as Int instead of UInt

[MaximeLM]

🌈

• I've read and understood the *CONTRIBUTING guidelines and have done my best effort to follow.

Report

What did you do?

In the Podfile of a Swift project, replace use_frameworks! with:

use_frameworks!(false)
use_modular_headers!

The project uses an Objective-C pod. The Objective-C pod use NSUInteger in its public interface.

What did you expect to happen?

NSUInteger should be cast in Swift as UInt. This is the previous behavior.

What happened instead?

NSUInteger is cast is Swift as Int. The swift project fails to compile.

CocoaPods Environment

Stack

   CocoaPods : 1.5.0
        Ruby : ruby 2.2.1p85 (2015-02-26 revision 49769) [x86_64-darwin14]
    RubyGems : 2.4.6
        Host : Mac OS X 10.13.4 (17E199)
       Xcode : 9.3 (9E145)
         Git : git version 2.15.1 (Apple Git-101)
Ruby lib dir : /Users/maximelemoine/.rvm/rubies/ruby-2.2.1/lib
Repositories : master - https://github.com/CocoaPods/Specs.git @ 4ddb0bcf3b52ed9ff3e40a475fb06d9dc264bcfe

Installation Source

Executable Path: /Users/maximelemoine/.rvm/gems/ruby-2.2.1/bin/pod

Plugins

cocoapods-amimono     : 0.0.10
cocoapods-deintegrate : 1.0.2
cocoapods-packager    : 1.5.0
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.0.0
cocoapods-trunk       : 1.3.0
cocoapods-try         : 1.1.0

Podfile

# Uncomment the next line to define a global platform for your project
platform :osx, '10.10'

# The project will compile with these settings
#use_frameworks!

# The project will fail to compile with these settings
use_frameworks!(false)
use_modular_headers!

target 'TestNSUInteger' do
  
  pod 'TestLib', :path => '.'

end

Project that demonstrates the issue

https://github.com/MaximeLM/TestNSUInteger.git

This is a simple project that demonstrates the issue. Reverting to use_frameworks!in the Podfile makes the project build again.

This issue is preventing apps that use RealmSwift to build with the new setting: realm/realm-swift#5663

[MaximeLM]

This seems to be caused by cd554f4

In the test project, the content of Pods/Headers/Public/TestLib/TestLib.modulemap is:

module TestLib [system] {
  umbrella header "TestLib-umbrella.h"

  export *
  module * { export * }
}

If I remove the [system] tag, the error is gone.

This thread indicates that NSUInteger is bridged as Int for system frameworks like Foundation/AppKit/UIKit, and as UInt for user frameworks.
https://lists.swift.org/pipermail/swift-users/Week-of-Mon-20160111/000848.html

[segiddins]

Well that’s unfortunate, and undocumented in the clang modules page :(. All it says the system modifier does is suppress warnings from headers

[dnkoutso]

We might have to remove this.

[gereons]

This issue also prevents apps using SwiftyDropbox from switching to use_frameworks!(false).

[dnkoutso]

PR #7638

[MaximeLM]

I still can't build RealmSwift with CocoaPods on the master branch. The Realm subpod defines a module map with framework module Realm, which is replaced by module Realm [system] by CocoaPods.
https://github.com/realm/realm-cocoa/blob/master/Realm/Realm.modulemap

CocoaPods/lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb

Line 628 in 0a93634

contents.gsub!(/^(\s*)framework\s+(module[^{}]+){/, '\1\2[system] {')

[dnkoutso]

1.5.1 hasn't shipped yet. did you try with latest master branch?

[dnkoutso]

Oops @MaximeLM you are right this should also be removed.

[dnkoutso]

Let me open a PR

[MaximeLM]

@dnkoutso yes I used the latest master

[dnkoutso]

@MaximeLM PR up

[MaximeLM]

@dnkoutso the app compiles with your fix, thank you!

Two warnings have appeared in our app:

Umbrella header for module 'Realm' does not include header 'RLMMigration_Private.h'
Umbrella header for module 'Realm' does not include header 'RLMSyncManager_Private.h'

I guess that is an issue with Realm?

[segiddins]

No, it’s a CocoaPods issue that we don’t know how to fix for static libraries