Add error-handling, whitespace-safety, and Rosetta support to scripts/ccl & scripts/ccl64 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent falling through on unknown architectures, and improve whitespace-safety.
galdor
reviewed
Jan 9, 2023
| echo "Unsupported architecture" | ||
| exit 1 ;; | ||
| esac ;; | ||
| Linux) |
There was a problem hiding this comment.
There might be an indentation issue here (or GitHub is not displaying things correctly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on my ARM Mac system, the
ccl64script had a fall-through case, which led to un-set shell parameters and eventually a confusing error message.This PR patches the
cclandccl64scripts to avoid such errors.I also hard-coded Rosetta support into the
casetree by using the x86-64 settings when ARM64 is detected and the environment variableCCL_USE_ROSETTA=1. I thought it was safer to require "opt-in" than "opt-out", given that there are apparently some problems running CCL under Rosetta (e.g. #356).