Write YAML file for KiboPush

[sojharo]

This task is to complete the YAML file for kibopush. I am assigning this to Anisha.

[AnishaChhatwani]

There are a total of 75 endpoints to be defined. It is quite a lengthy task and is time consuming as I have to think what parameters are required for each endpoint and understand which endpoint returns what. Basically, have to go through all the server side code of KiboPush.
I have defined 8 endpoints till now.

[jekram]

@AnishaChhatwani What is the update here?

[AnishaChhatwani]

Defined 12 endpoints today. So a total of 20 endpoints are defined till now

[AnishaChhatwani]

This task is done. Defined all the endpoints

[AnishaChhatwani]

@sojharo Please test

[sojharo]

Yes, I have tested it. Asked Anisha to change security definition from token to API keys.

[sojharo]

Anisha has added the security definition. I have tested it and we can close it now. In the next task, I would integrate this YAML file into our application #1210

[jekram]

Thanks

[saniasiddiqui]

There are some problems I have come across while implementing client APIs
Pages (QUERIES)
1.We have three apis /pages/, pages/allpages/, pages/otherpages. The information retrieved is more or less same for all.
/pages/ : list of all connected pages
pages/allpages/ : list of all connected pages with no.of subscribers.
2.

We have apis like /page_survey/,/page_poll/, page_broadcast/. It is giving me almost same information as /survey/,/polls/,/broadcasts/. Why are we needing these apis ?

[saniasiddiqui]

Polls (BUG)
1.

The responseCount format in /polls/ api is not correct.
The object it returns is of the format {_id : '', count: ''}.
We need to correct the definition.
2.

Response from /polls/
This is the information we retrieve from /polls/ api.
The data returned from responseCount is also not correct. We need to check from which table it is coming. Probably it is showing id of some old polls.

[saniasiddiqui]

WorkFlows (BUG)

1.This is the payload for workflows. However the information format we receive for a sample data is : [ { _id: '5a1fc5ae6171c8512304c0ea',
condition: 'message_is',
reply: 'How has been your day',
isActive: true,
userId: '5a1fc3a16171c8512304c0e6',
sent: 0,
__v: 0,
datetime: '2017-11-30T08:47:42.736Z',
keywords: [ 'HEY' ] } ]

[jekram]

@saniasiddiqui I am not understanding your comments?

Are you asking questions?

or you are reporting a bug?

[saniasiddiqui]

These are the problems I am coming across. Where we need to update yaml definition, that is a bug.
And some api definitions are not clear, that are questions.
Do we need to track bugs in separate issues?

[jekram]

@saniasiddiqui If these are bugs then you should have removed the "Resolved" status and added "Bug" status and notify @AnishaChhatwani. Also, you should ping @AnishaChhatwani and get clarity from her. You have a mix of questions and issues in your comments.

[AnishaChhatwani]

When I was working for operational dashboard, fixed these issues side by side and created a pull request under operational dashboard's issue number.. Therefore, u don't see a merge here

[saniasiddiqui]

Pages Bugs

1. Resolved
2. Resolved

Poll Bugs

1. Resolved
2. Issue#1315 Opened

Workflows Bugs

1. Resolved

Dashboard Bugs

1. Resolved
2. Resolved

Sessions Bugs

1. Resolved
2. Resolved
3. Resolved
4. Resolved
5. Resolved

We should remove /broadcasts/download from yaml as it is not being used anywhere. @sojharo
After this we can mark these issues resolved.

[saniasiddiqui]

Send Poll /polls/send (Bug)

Steps:

1. Login in to Sample App using app_id and app_key credentials
2. Go to Polls
3. Send Polls
4. Receive poll on fb messenger
5. Respond the poll
6. The poll response is not saved on our kibopush server as it doesn't show up on staging and client api as well.
   Note: When we send a poll using staging kibopush application, the response is shown both on staging and client api.
   @sojharo. For an end to end use case to be implemented at client side we need to look for possible code or design issue here.

[sojharo]

We can close this task. Please open a separate task.

[saniasiddiqui]

Bug:
Payload Description for /surveys/create and /surveys/edit/ is not correct.

[jekram]

@saniasiddiqui when you reopen the task. Please remove resolved for it.

@AnishaChhatwani please look into this

[AnishaChhatwani]

This is done. @saniasiddiqui please test

[saniasiddiqui]

This isa sample response for create Surveys.

{
"status": "success",
"payload": {
"__v": 0,
"title": "Survey ABC",
"userId": "5a1fc3a16171c8512304c0e6",
"_id": "5a55a57b8dc9e96f50cf639b",
"isresponded": 0,
"segmentationGender": [],
"segmentationLocale": [],
"segmentationPageIds": [],
"isSegmented": false,
"datetime": "2018-01-10T05:32:43.239Z"
}
}

[AnishaChhatwani]

This is fixed. @saniasiddiqui please test again

[saniasiddiqui]

Tested. Changes asked have been incorporated.
Thanks

[jekram]

Thanks