Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bemenu appears on all outputs with wayland #80

Closed
NilsIrl opened this issue Jan 11, 2020 · 5 comments
Closed

Bemenu appears on all outputs with wayland #80

NilsIrl opened this issue Jan 11, 2020 · 5 comments
Labels

Comments

@NilsIrl
Copy link

NilsIrl commented Jan 11, 2020

-m (--monitor) also does not work on Wayland

@Cloudef
Copy link
Owner

Cloudef commented Jan 11, 2020

The -m option isn't implemented for the wayland renderer.

I guess it could be implemented by modifying the section here:
https://github.com/Cloudef/bemenu/blob/master/lib/renderers/wayland/wayland.c#L279

menu->monitor will contain the value passed to -m by default it should be 0. Bemenu for each monitor doesn't exist in X11, so I'm not sure how that should encoded if that behavior needs to be retained.

X11 renderer also implements set_monitor function, that allows the monitor to be changed runtime, that might be bit more involved task for wayland. Not implementing it means that bm_menu_set_monitor needs to be called before the menu is rendered first time.

@NilsIrl
Copy link
Author

NilsIrl commented Jan 11, 2020

so I'm not sure how that should encoded if that behavior needs to be retained.

I can't find a reason to keep the feature/bug of it being on every monitor/output.

@Cloudef
Copy link
Owner

Cloudef commented Feb 8, 2020

178a582
Maybe it works

@Cloudef Cloudef closed this as completed Feb 8, 2020
@ppascher
Copy link
Contributor

For me at least it was a nice feature to have bemenu shown on all outputs. It felt more natural to be looking at the monitor I want the application to open on while using bemenu. Especially with bemenu not being shown a layer above a fullscreen window (though this is possibly a bug with wlroots according to issue #81 ). Maybe it is possible to make it configurable?

@Cloudef
Copy link
Owner

Cloudef commented Feb 17, 2020

maybe I could restore the old behavior with -m -1 for wayland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants