Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tasks from the SyncProxy tablist #1385

Open
1 task done
DinoMarlir opened this issue Apr 5, 2024 · 5 comments
Open
1 task done

Exclude tasks from the SyncProxy tablist #1385

DinoMarlir opened this issue Apr 5, 2024 · 5 comments
Labels
in: module An issue/pull request releated to one of the internal modules t: feature request A request of a feature someone wants to see in a future release. v: 4.X This pull should be included in the 4.0 release

Comments

@DinoMarlir
Copy link

DinoMarlir commented Apr 5, 2024

Describe the new feature

It would be nice if you could exclude tasks from the tablist configuration.

Why do you need this feature?

Because some services have their own tablist (plugins, etc)

Alternatives

there are no alternatives

Other

No response

Issue uniqueness

  • Yes, this issue is unique. There are no similar issues.
@DinoMarlir DinoMarlir added s: needs triage Issue waiting for triage t: feature request A request of a feature someone wants to see in a future release. labels Apr 5, 2024
@0utplay
Copy link
Member

0utplay commented Apr 5, 2024

Do you have any implementation ideas? As far as I can tell this would require us to only set the tablist when a player is connected to a service from a specific task. But we also have to reset the tablist when the player connects to a task which is excluded. Wouldn't this create the problem that we would overwrite already set tablists from other plugins by resetting?

@DasBabyPixel
Copy link
Contributor

Clear the tablist before server change. No service can have set a tablist at that point
Velocity: ServerPreConnectEvent.
Bungee: ServerConnectEvent
Waterdog: PreTransferEvent

@0utplay
Copy link
Member

0utplay commented Apr 10, 2024

If some is willing to implement this properly I'm open to merge that.

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: module An issue/pull request releated to one of the internal modules and removed s: needs triage Issue waiting for triage labels Apr 10, 2024
@DinoMarlir
Copy link
Author

@0utplay I'm working on it. 👍

@0utplay
Copy link
Member

0utplay commented May 16, 2024

is there any progress on this @DinoMarlir ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: module An issue/pull request releated to one of the internal modules t: feature request A request of a feature someone wants to see in a future release. v: 4.X This pull should be included in the 4.0 release
Projects
None yet
Development

No branches or pull requests

3 participants