Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index name clash for multiple models. #129

Merged
merged 1 commit into from
Nov 26, 2014

Conversation

rselk
Copy link
Contributor

@rselk rselk commented Oct 13, 2014

No description provided.

@rselk rselk changed the title fix index name clash for multiple models fix index name clash for multiple models. fixes #128 Oct 14, 2014
@rselk rselk changed the title fix index name clash for multiple models. fixes #128 fix index name clash for multiple models. Oct 14, 2014
@rselk
Copy link
Contributor Author

rselk commented Oct 14, 2014

fixes #128

@mceachen
Copy link
Collaborator

 NoMethodError:
   undefined method `migration_template' for #<ClosureTree::Generators::MigrationGenerator:0x00000004470c58>

@seuros
Copy link
Member

seuros commented Oct 14, 2014

Weird, error. Tests pass locally.
@mceachen do you have an idea about this error ?

@mceachen
Copy link
Collaborator

I've never used that gem before, so we'll have to see what it's trying to
do.

Odd that they pass locally though.

@rselk rselk force-pushed the multiple_models branch 2 times, most recently from b5088cf to 127d56a Compare October 14, 2014 22:10
@seuros
Copy link
Member

seuros commented Oct 15, 2014

:shipit:

@mceachen
Copy link
Collaborator

mceachen commented Nov 3, 2014

I found out that if the generator tests run in a separate process from the other tests, everything is fine.

I created yet another spec group just for your new spec, and https://travis-ci.org/mceachen/closure_tree/builds/39798412 just passed, so finger's crossed...

seuros added a commit that referenced this pull request Nov 26, 2014
fix index name clash for multiple models.
@seuros seuros merged commit f3bf345 into ClosureTree:master Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants