Ensure chrX and X are treated equally #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fellen31
force-pushed
the
fix-chr
branch
7 times, most recently
from
7f802ed to
7d1e341
Compare
fellen31
force-pushed
the
fix-chr
branch
2 times, most recently
from
6677c92 to
9b143ef
Compare
torbjorgen
approved these changes
Oct 7, 2024
| variant: Dict[str, str] = get_variant_dict(line, header.header) | ||
| variant['info_dict'] = get_info_dict(variant['INFO']) | ||
| yield variant | ||
|
|
There was a problem hiding this comment.
One suggestion would be to move the variant generation methods into a fixture in the functionality module, so that we reduce duplicate code, related fellen31@bc15a2f
There was a problem hiding this comment.
Thanks for the review @torbjorgen, I'll look into moving it into a fixture, and just ping you afterwards so you can make sure it looks ok.
|
I don't think I have enough experience with pytest yet @torbjorgen to fully understand how to best solve this. I don't want to make the codebase worse, but I also know this project is not a priority. Is moving the common functions to a test_utils.py an okay middle way to reduce code duplication without dealing with pytest fixtures? |
torbjorgen
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #132.
Adds a VCF file with
chrprefix, and a test to check that models are equal between both files. I don't know that much python/pytest so let me know if the code can be improved.Added
Changed
Fixed
chrXand notX.How to prepare for test
uspaxaHow to test
Expected test outcome
Review
Thanks for filling in who performed the code review and the test!
This version is a
Implementation Plan