Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector Housekeeping #30

Open
BentsiLeviav opened this issue Oct 16, 2024 · 7 comments
Open

Connector Housekeeping #30

BentsiLeviav opened this issue Oct 16, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@BentsiLeviav
Copy link
Collaborator

There are two things we would like to change, that would provide a better user experience:

  1. Link the learn more part to the connector's official docs instead of the ClickHouse home page
    image

  2. When throwing an exception on ODBC absence, provide a link to the ODBC installation docs
    image

@BentsiLeviav BentsiLeviav added the enhancement New feature or request label Oct 16, 2024
@BentsiLeviav BentsiLeviav self-assigned this Oct 16, 2024
@BentsiLeviav
Copy link
Collaborator Author

Would also want to update the docs to include new screenshots (new versions of PowerBI and ClickHouse Cloud)

@BentsiLeviav
Copy link
Collaborator Author

Would also want to turn off the beta flag

@BentsiLeviav
Copy link
Collaborator Author

We also need to update the ClickHouse docs regarding our support for PowerBI service.

@laeg
Copy link

laeg commented Oct 24, 2024

We should also update the label in ODBC connector setup screen to be Host instead of Server to align with our documentation/naming convention

image

@BentsiLeviav
Copy link
Collaborator Author

  • The documentation was updated at #Update PowerBI doc clickhouse-docs#2734
  • We couldn't update CH cloud screenshots, as we import them as a snippet (and many other pages use it). I opened an issue in the docs repo #Update screenshots in _gather_your_details snippet clickhouse-docs#2733
  • A link to the ODBC installation guide link is provided when the connector throws an exception about missing driver
  • The "learn more" link was changed to the official docs
  • The Beta flag was removed
  • The field name was changed from Server to Host (due to the fact that the parameter name in ODBC is Server, I kept the code as is and only changed the UI).

All these changes are in changes-for-certification-process

@laeg
Copy link

laeg commented Oct 28, 2024

@BentsiLeviav i noticed the images still show Beta? will we need to another docs update later?

@BentsiLeviav
Copy link
Collaborator Author

@laeg That's right, it is either having a screenshot with a beta flag or with a Custom indication like the following:
image

Once the MS team publishes the new version, we will have a clean screenshot to add.
I'll reopen this issue to keep this in mind.

@BentsiLeviav BentsiLeviav reopened this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants