-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/apply incremental schema changes #332
Merged
BentsiLeviav
merged 11 commits into
ClickHouse:main
from
canbekley:feat/apply-incremental-schema-changes
Aug 21, 2024
Merged
Feat/apply incremental schema changes #332
BentsiLeviav
merged 11 commits into
ClickHouse:main
from
canbekley:feat/apply-incremental-schema-changes
Aug 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BentsiLeviav
reviewed
Aug 5, 2024
dbt/include/clickhouse/macros/materializations/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
Github changed its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
implementation of schema changes for incremental models are currently missing. detecting schema changes during materialization would fallback to the legacy incremental strategy. this is not user-friendly and not feasible for very large models. schema changes for distributed_incremental materialization were not supported at all.
this pr contains
incremental
anddistributed_incremental
materializationson_schema_change='sync_all_column'
strategy as per official dbt specson_schema_change='ignore'
, where new columns in the target relation would break the dbt run during creation of the__dbt_new_data_
tablesChecklist
Delete items not relevant to your PR: