Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message is too verbose #1677

Closed
chernser opened this issue Jun 7, 2024 · 2 comments · Fixed by #1680
Closed

Error message is too verbose #1677

chernser opened this issue Jun 7, 2024 · 2 comments · Fixed by #1680
Labels

Comments

@chernser
Copy link
Contributor

chernser commented Jun 7, 2024

Describe the bug

There are several problems:

  • Exception message is too verbose.
    • Client is adding server information what can be sensitive information (for service providers)
  • Server message is appended with unrelated to the error information.
    image

Expected behaviour

  • ClickHouseException message should contain only error message. No context information like server should present
@chernser chernser added the bug label Jun 7, 2024
@Paultagoras
Copy link
Contributor

Is that considered sensitive information? In much the same way a stack trace can help, I think outputing the environment can help diagnose misconfigurstion - don't want to share passwords though, of course...

@Paultagoras Paultagoras assigned Paultagoras and mzitnik and unassigned mzitnik and Paultagoras Jun 7, 2024
@chernser
Copy link
Contributor Author

chernser commented Jun 7, 2024

@Paultagoras it is fine to have it in logs. Exception messages should be very straightforward and only about error.
Exception may have some context saved within itself and it may be accessible by application for the debugging.

@chernser chernser linked a pull request Jun 7, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants