Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R2DBC deferred connection creation #1447

Closed
pboklashov opened this issue Sep 12, 2023 · 1 comment
Closed

R2DBC deferred connection creation #1447

pboklashov opened this issue Sep 12, 2023 · 1 comment
Labels
Milestone

Comments

@pboklashov
Copy link

pboklashov commented Sep 12, 2023

Description

According to R2DBC specification, ConnectionFactory implementation must deffer connection creation (https://r2dbc.io/spec/1.0.0.RELEASE/spec/html/#connections.factory). ClickHouseConnectionFactory created connection when ClickHouseConnectionFactory#create is called.

Therefore tools that rely on deferred connection creation (for instance, r2dbc-pool) always gets the same connection instance, close all instances at once, and then get only already closed connections from ClickHouseConnectionFactory#create.

Steps to reproduce

  1. Create several connection using Mono created by ClickHouseConnectionFactory#create
  2. Observe that instance of Connection is always the same

Expected behaviour

Mono, returned by ClickHouseConnectionFactory, creates new instance of Connection on each subscription.

Configuration

Environment

  • Client version: 0.4.6
@pboklashov pboklashov added the bug label Sep 12, 2023
@chernser chernser added this to the 0.7.0 milestone Sep 6, 2024
@chernser
Copy link
Contributor

chernser commented Sep 6, 2024

Fix merged

@chernser chernser closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants