Reload remote_url_allow_hosts after config update. #35294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
mdonkers
reviewed
Mar 15, 2022
src/Common/RemoteHostFilter.cpp
Outdated
Comment on lines
38
to
39
| std::lock_guard guard(hosts_mutex); | ||
|
|
There was a problem hiding this comment.
Necessary also to run
primary_hosts.clear()
regexp_hosts.clear()
before adding the new entries? Otherwise previous configuration is retained in the list?
I assume the lock will make sure checkForDirectEntry won't be executed concurrently while the lists are updated, and thus might execute against empty lists then?
There was a problem hiding this comment.
ah, indeed, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Reload
remote_url_allow_hostsafter config update.