Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kwargs issue on GPUs #164

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Fix kwargs issue on GPUs #164

merged 1 commit into from
Feb 24, 2024

Conversation

dennisYatunin
Copy link
Member

Purpose

It looks like the fix to #144 applied in #157 did not work in ClimaAtmos (see this build), and several test cases now have a garbage collection instruction that is breaking GPU compilation. Replacing kwargs in some methods of the obukhov_length function with regular args fixes this issue. Since these are internal methods, they probably shouldn't have kwargs anyway.


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (c1c7df6) to head (f54533e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files           4        4           
  Lines         827      827           
=======================================
  Hits          743      743           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charleskawczynski
Copy link
Member

Thanks, @dennisYatunin!

@charleskawczynski charleskawczynski merged commit 3510794 into main Feb 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants