Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpointer warning if properties included make restoring impossible #417

Closed
ali-ramadhan opened this issue Sep 18, 2019 · 1 comment · Fixed by #628
Closed

Checkpointer warning if properties included make restoring impossible #417

ali-ramadhan opened this issue Sep 18, 2019 · 1 comment · Fixed by #628
Labels
bug 🐞 Even a perfect program still has bugs

Comments

@ali-ramadhan
Copy link
Member

ali-ramadhan commented Sep 18, 2019 •
edited
Loading

Right now the `Checkpointer docstring says

Note that extra model `properties` can be safely specified, but removing
crucial properties such as `:velocities` will make restoring from the
checkpoint impossible.

Would be good to print a warning if something crucial is missing from properties.
@ali-ramadhan ali-ramadhan added the bug 🐞 Even a perfect program still has bugs label Sep 18, 2019
@glwagner
Copy link
Member

How about adding them automatically, coupled with emission of an @info or @warn?

@ali-ramadhan ali-ramadhan mentioned this issue Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify checkpointer and make it work for large models CliMA/Oceananigans.jl
2 participants
@glwagner @ali-ramadhan