-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming NetCDFOutputWriter
to NetCDFWriter
#3936
Comments
I'm in support of this change! |
Happy for this. It affects #3793, maye we just use |
I wasn't aware of that PR. I like it and I'll interact with it soon :) I still think this (what I'm proposing) would be a positive change, although I agree its importance will be diminished after that PR is merged (that's part of the point if I understand correctly). Since that PR seems not very close to be merged my thinking is that we should go for this changer in the output writer naming convention. What do you think? |
#3793 is probably 30 minutes of work from completion, don't you think? |
We've talked about this before, since the "Output" part is pretty redundant and that name is on the verbose side. The same thing applies to
JLD2OutputWriter
. Should I go ahead and open a PR to make this change?The text was updated successfully, but these errors were encountered: