Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in WENOVectorInvariant constructor #3865

Closed
glwagner opened this issue Oct 24, 2024 · 1 comment · Fixed by #3864
Closed

Bug in WENOVectorInvariant constructor #3865

glwagner opened this issue Oct 24, 2024 · 1 comment · Fixed by #3864
Labels
bug 🐞 Even a perfect program still has bugs

Comments

@glwagner
Copy link
Member

required_halo_size does not exist:

Oceananigans.jl/src/Advection/vector_invariant_advection.jl

Line 215 in 03b8acf

N = maximum(required_halo_size(s) for s in schemes)

I guess it's not tested.
@glwagner glwagner added the bug 🐞 Even a perfect program still has bugs label Oct 24, 2024
@glwagner
Copy link
Member Author

@simone-silvestri

@glwagner glwagner mentioned this issue Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Even a perfect program still has bugs
Projects
None yet
Milestone
No milestone
1 participant
@glwagner