Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpointer required properties includes :architecture despite it can be inferred from grid #3463

Closed
navidcy opened this issue Feb 7, 2024 · 1 comment · Fixed by #3461
Closed

Checkpointer required properties includes :architecture despite it can be inferred from grid #3463

navidcy opened this issue Feb 7, 2024 · 1 comment · Fixed by #3461
Labels
output 💾 question 💭 No such thing as a stupid question

Comments

@navidcy
Copy link
Collaborator

navidcy commented Feb 7, 2024

I don't think architecture is required, despite being included here:

Oceananigans.jl/src/OutputWriters/checkpointer.jl

Line 74 in 3b02321

required_properties = (:grid, :architecture, :timestepper, :particles)

For example, :architecture property is not called within

Oceananigans.jl/src/OutputWriters/checkpointer.jl

Line 201 in 3b02321

function set!(model, filepath::AbstractString)

@navidcy navidcy added question 💭 No such thing as a stupid question output 💾 labels Feb 7, 2024
@navidcy navidcy changed the title Checkpointer required properties includes :architecture but it can be inferred from grid Checkpointer required properties includes :architecture despite it can be inferred from grid Feb 7, 2024
@glwagner
Copy link
Member

glwagner commented Feb 7, 2024

Makes sense. Checkpointer needs love.

@navidcy navidcy mentioned this issue Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
output 💾 question 💭 No such thing as a stupid question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhance Checkpointer + TendencyCallsite callback example CliMA/Oceananigans.jl
2 participants
@navidcy @glwagner