Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression test(s) for SplitExplicitFreeSurface #3335

Closed
glwagner opened this issue Oct 12, 2023 · 2 comments · Fixed by #3373
Closed

Regression test(s) for SplitExplicitFreeSurface #3335

glwagner opened this issue Oct 12, 2023 · 2 comments · Fixed by #3373
Labels
testing 🧪 Tests get priority in case of emergency evacuation

Comments

@glwagner
Copy link
Member

We need regression tests for SplitExplicitFreeSurface on serial and distributed architectures.

cc @simone-silvestri
@glwagner glwagner added the testing 🧪 Tests get priority in case of emergency evacuation label Oct 12, 2023
@navidcy
Copy link
Collaborator

navidcy commented Nov 2, 2023

@simone-silvestri we do have some of these now in the distributed test suite, right?

@simone-silvestri
Copy link
Collaborator

They are already there,

Oceananigans.jl/test/test_hydrostatic_regression.jl

Line 80 in 7291ada

for free_surface in [explicit_free_surface, implicit_free_surface, split_explicit_free_surface]

we have to merge in OceananaigansArtifacts the branch and correct main to download from OceananaigansArtifacts#main. I ll open a PR there

@simone-silvestri simone-silvestri mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update regression test data CliMA/Oceananigans.jl
3 participants
@navidcy @glwagner @simone-silvestri