-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using ImmersedBoundaryGrid
with HydrostaticModel
and drag boundary condition
#2711
Comments
this is on |
hydrostatic and nonhydrostatic models use the same code for enforcing boundary conditions. |
We could think to change the dependencies to all fields instead of only the prognostic ones |
I wasn't aware of that. Is there a way to use |
It might make sense to follow @simone-silvestri's suggestion and include all fields in Here though, the thinking may not be correct. The hydrostatic approximation is an asymptotic approximation predicated on |
Just to make sure I understand correctly: you're talking about expanding the use of the already-existing keyword argument If that's correct, I don't see why not. It'd make the code more flexible. |
I believe we used to include "all fields" (meaning, prognostic fields and some diagnostic fields like pressures, diffusivities, and perhaps vertical velocity). However, diffusivities associated with tuples of closures created issues. Perhaps if we include "velocities, tracers, and auxiliary fields", we will be in a good place. I think we should provide the same list of fields to forcing functions as well as boundary conditions so that API behavior is easier to remember. The reason not to include more fields is #2700. |
Velocities, tracers, and auxiliary fields seems pretty good already. I completely agree with this. |
In light of #2700, let's make sure we have a good reason / sustainable strategy for adding this potentially expensive feature. |
@tomchor is this still an issue? |
Just tested it and it runs fine: julia> run!(simulation)
[ Info: Initializing simulation...
[ Info: ... simulation initialization complete (11.290 seconds)
[ Info: Executing initial time step...
[ Info: ... initial time step complete (26.266 seconds).
[ Info: Simulation is stopping after running for 41.963 seconds.
[ Info: Model iteration 10 equals or exceeds stop iteration 10. |
When I run the following MWE:
I get the following error:
I'm not very familiar with hydrostatic models. Is this a bug or am I missing something?
The text was updated successfully, but these errors were encountered: