Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more chatty, more friendly Oceananigans #1013

Closed
glwagner opened this issue Sep 30, 2020 · 3 comments
Closed

A more chatty, more friendly Oceananigans #1013

glwagner opened this issue Sep 30, 2020 · 3 comments
Labels
abstractions 🎨 Whatever that means feature 🌟 Something new and shiny

Comments

@glwagner
Copy link
Member

Sometimes precompilation and model setup tasks can take a fair amount of time. This can lead to head-scratching and/or boredom while running scripts: what is Oceananigans up to, anyways?

To solve this problem and make Oceananigans more friendly and more chatty, we might add some helpful @info messages that print at various stages in the model setup process.

Looking at the examples gives a helpful overview of model setup. Here's some things we might consider info statements for:

  1. Grid creation (type, size, topology, domain)
  2. Boundary conditions (type and non-default boundary conditions)
  3. Model creation (grid info including size and halo regions, and maybe just display model properties)
  4. set!(model, ...)?
  5. Simulation construction (stop criteria, time-step...)
  6. run! initialization (diagnostics, output writers)
  7. run! completion?
@glwagner
Copy link
Member Author

glwagner commented Oct 1, 2020

Should we define new log levels for this purpose? It's less committing to add "maor logging" when they can be turned off. For example we can have a MODEL (or SETUP) level, and maybe a SIMULATION level...

@tomchor
Copy link
Collaborator

tomchor commented Jan 29, 2021

(Sorry, I accidentally unpinned this issue but just re-pinned it)

@navidcy navidcy unpinned this issue Mar 17, 2021
@glwagner
Copy link
Member Author

glwagner commented Mar 2, 2022

Simulation is pretty chatty now so I think we can close this.

@glwagner glwagner closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abstractions 🎨 Whatever that means feature 🌟 Something new and shiny
Projects
None yet
Development

No branches or pull requests

3 participants