Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toml dict is missing LH_f0 #92

Open
charleskawczynski opened this issue Jun 20, 2022 · 2 comments
Open

Toml dict is missing LH_f0 #92

charleskawczynski opened this issue Jun 20, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@charleskawczynski
Copy link
Member

ClimaLSM uses LH_f0, this was defined in Planet parameters, and the toml dict is missing it.

@charleskawczynski charleskawczynski added the bug Something isn't working label Jun 20, 2022
@charleskawczynski
Copy link
Member Author

Ah, again this was a derived parameter, I suppose we can define all derived parameters in a distributed fashion?

@odunbar
Copy link
Contributor

odunbar commented Jan 25, 2023

https://github.com/CliMA/CloudMicrophysics.jl/blob/5376eab9933bf96ae6c2a1a5330a6d2b37a9ea2d/src/Parameters.jl#L125-L140

I believe this sets the current conventions.

  1. Parameter objects in a package, generally inherit (though not necessarily) parameters from dependent packages.
  2. Derived parameters are functions of the parameter-containing object
  3. Derived parameters in package B and A, add a method to the function definition for set B

I'm ok with the current convention as we have started, by simply transferring the method to PPS
LH_f0(ps::PS) = TD.Parameters.LH_f0(thermodynamics_params(ps))
which can be done once per repo, and doesn't need code copying. Note that this does not disallow the choice to reload parameters and define derived parameter functions in a distributed fashion too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants