Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_parameter_values! is confusingly named #152

Open
glwagner opened this issue Nov 17, 2023 · 0 comments
Open

get_parameter_values! is confusingly named #152

glwagner opened this issue Nov 17, 2023 · 0 comments

Comments

@glwagner
Copy link
Member

because it does not return values, it returns "pairs":

function ThermodynamicsParameters(toml_dict)

    # Used in thermodynamics, from parameter file
    aliases = [ ..., "gas_constant", "molmass_dryair"]

    param_pairs = CLIMAParameters.get_parameter_values!(
        toml_dict,
        aliases,
        "Thermodynamics",
    )
    nt = (; param_pairs...)

    FT = CP.float_type(toml_dict)
    return ThermodynamicsParameters{FT}(; nt...)
end

from the docs.

cc @odunbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant