Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent_leaky_tests = false results in failure #1826

Open
charleskawczynski opened this issue Jun 18, 2024 · 0 comments · Fixed by #1857
Open

prevent_leaky_tests = false results in failure #1826

charleskawczynski opened this issue Jun 18, 2024 · 0 comments · Fixed by #1857
Labels
bug Something isn't working CI Issues releated to CI

Comments

@charleskawczynski
Copy link
Member

Unfortunately, we can't yet run with prevent_leaky_tests = false (which could be a decent bit faster) because we occasionally define global constants, which clash with local variables:

Spaces - serial CPU DSS: Error During Test at none:1
  Got exception outside of a @test
  LoadError: cannot declare Main.device constant; it already has a value
  Stacktrace:
    [1] top-level scope
      @ ~/Dropbox/Caltech/work/dev/CliMA/ClimaCore.jl/test/Spaces/ddss1.jl:21
    [2] include(fname::String)
      @ Base.MainInclude ./client.jl:489
...
@charleskawczynski charleskawczynski added bug Something isn't working CI Issues releated to CI labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Issues releated to CI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant